-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] The PowerShell extension-related fixes #102
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
azatsarynnyy
changed the title
[WIP] Test running the remote terminal sessions through the extension API
[WIP] The PowerShell extension-related fixes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi [email protected]
What does this PR do?
The
che-commands
extension relies on theche-terminal
extension's API for running the Devfile Commands in any container via the machine-exec server.See more details in the comment PowerShell VS Code extension failed to start eclipse-che/che#21626 (comment).
What issues does this PR fix or reference?
che
type eclipse-che/che#21466Shell integration
breaks the auto-opened terminal in Che-Code eclipse-che/che#21616How to test this PR?
Test opening the terminals
Use case 1: there're multiple contributed containers
Terminal: Create New Terminal to DevWorkspace Container
.Use case 2: there's one contributed container (except for the editor's container)
Terminal: Create New Terminal to DevWorkspace Container
.mariadb
) except the editor's container.mariadb
.Use case 3: there're no contributed containers (except for the editor's container)
In this case, the behavior should be exactly the same as opening a built-in VS Code terminal.
Terminal: Create New Terminal to DevWorkspace Container
.tools
.Test running the tasks
tasks.json
with ashell
task. E.g.:Terminal > Configure Tasks... > Create tasks.json file from template > maven
.shell
task.che
type eclipse-che/che#21466Test PowerShell extension functionality
PowerShell
extension.pwsh
is contributed to theLaunch Profile...
menu.*.ps1
file), a new terminalPowerShell Extension
is launched automatically.*.ps1
file work as expected.PowerShell
left-side panel is populated with the commands.View
>Output
).